Repository navigation
feat(console): read-only holdings panel from broker_reported_positions - #617
Merged
Merged
Conversation
Pigbibi
force-pushed
the
rebuild/console-holdings-panel
branch
from
October 11, 2026 06:31
00c7a4e to
7956090
Compare
Pigbibi
marked this pull request as ready for review
October 11, 2026 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for owner review. Do not merge or deploy without separate owner approval. Release order is receiver first (publishers still strip holdings), then verified runtime report evidence, then separately approved publisher enablement. Publisher enablement is NOT a prerequisite for releasing the compatible receiver.
Receiver (account_facts.js)
/api/account-facts/synchistory accepts optionalbroker_reported_positions+broker_reported_positions_scope, as a pair. Scope is fixed per platform: IBKRstocks_only, Schwabstrategy_symbols_only; other platforms reject it.invalid_account_facts_positions); an empty list is never stored.positions/positions_scopeonly while the snapshot is fresh. Older history without positions stays readable.Frontend
Follow-ups (separate PRs)
publish_account_facts_from_report.pyand Schwabpublish_account_facts_from_reports.pycurrently stripARCHIVE_ONLY_KEYSbefore publish. Stop stripping only after this receiver is live.Merging auto-deploys the live console (
deploy-strategy-switch-console.ymlon push to main forweb/strategy-switch-console/**). Owner approval is required. This PR will also need a rebase on whichever console PR lands first, becausev2_asset_map.jsis regenerated.Release / rollback runbook
Additional verification
v2_asset_map.jsmatches the existing committed file exactly.