Repository navigation
feat: audit snapshot completeness and retain daily Binance detail - #1021
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Pigbibi
commented
Nov 1, 2026
Pigbibi
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review completed for head 03e3d5f after the configured Python/JavaScript CI passed. This is the implementing assistant's review, not an independent human or CodeRabbit approval.
- Verified independently bounded calendar dates, unknown source states, empty-result proof, private identity matching and stop-on-access/identity failures.
- Corrected two findings: null/unknown completeness configuration cannot pass, and backfill readback revalidates a concurrently newer incomplete observation. The 19 focused regression tests pass.
- Verified Binance daily native detail uses the existing Durable Object transaction and validated readback, preserves source/date identity, rejects conflicts and remains separate from the expiring latest cache.
- Reviewed the final public diff for account/resource/credential data; Gitleaks and documentation checks pass.
- No remaining blocking findings in the code diff. Activation still needs the separately approved private account/calendar/field inventory, image deployment, IAM/secret wiring and cloud schedule. Historical gaps and uncollected broker fields remain incomplete.
The owner-approved label and squash merge are authorized by the user's current task instruction; they do not authorize cloud activation or trading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex, using the host-selected GPT-6 model settings.
What changed
Add a cloud-only cross-platform archive completeness audit and retain full daily Binance native account detail beyond the two-day latest-cache TTL. Expected dates come from an independently bounded session calendar or continuous UTC calendar, so leading, trailing and entirely missing histories are detected.
The guard validates source identity, observation dates, cash/positions/orders/fills and explicit evidence for empty results. It reads GCS generations, records private audit readback, emits redacted Telegram alerts with uncertain-send suppression, and provides disabled-by-default real-history-only backfill hooks. Binance ingestion persists and reads back full daily detail in the existing Durable Object before acknowledging publication; a dedicated authenticated archive GET exposes one requested day.
A Cloud Run Job container and synthetic configuration describe adoption. There are no deployment, IAM, secret, scheduler or trading changes. Private account/calendar/field mappings and cloud activation require separate owner sign-off. Existing unavailable history and unsupported broker fields remain incomplete.
Coordination: QuantStrategyLab/LongBridgePlatform#685 owns its PAPER collector/watchdog. This PR does not modify that implementation or inherit its cloud authorization.
How verified
Risk and rollback
The new Binance detail table intentionally has no TTL. The ingestion path fails publication when archive persistence/readback fails. Existing latest KV and wallet-summary contracts remain unchanged. The archive endpoint uses the dedicated Binance facts bearer token and active trusted binding; retired binding read access is not newly granted. Revert the code or restore the prior reviewed image before activation; preserve archived records. Stop for owner approval before any cloud activation or permission/secret changes.