Repository navigation
fix: surface catalog-external strategy bindings and resolve aliases - #1004
Merged
Merged
Conversation
- strategy summary matches accounts to catalog profiles through the generated alias map, so a legacy alias no longer disappears from its strategy card - bindings whose profile the catalog no longer declares are returned as unmatched_strategy_assignments and rendered in their own Strategies section instead of being silently dropped - worker catalog, DCA, option-overlay and frozen-default comparisons resolve the same aliases, keeping account-strategy matching consistent - domain allowlists derive from the generated platform config instead of a second hardcoded list - digest workflow allowlist no longer carries a duplicate fallback copy; the platform config is the only source
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Pigbibi
added
the
owner-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI
Generated and verified by an AI agent. All fixtures are synthetic; no private identifiers are introduced.
What changed
application/console_api/operations.js: strategy summary now matches bound accounts through the generated alias map, and returnsunmatched_strategy_assignmentsfor bindings whose profile the catalog no longer declares.frontend/src/pages/strategies/StrategiesPage.tsx: renders those bindings in a dedicated "Bindings outside the catalog" section with the raw profile id, instead of silently dropping the account.worker.js/ newstrategy_identity.js: one canonical alias resolver is used by catalog lookup, DCA capability, option-overlay, frozen-default and draft checks, so a legacy alias is the same strategy rather than an unconfigured one.worker.js:SUPPORTED_STRATEGY_DOMAINSis derived fromPLATFORM_CONFIG(generated fromplatform-config.json) instead of a second hardcoded list.python/scripts/daily_digest_aggregator.py: removed the duplicated workflow-allowlist fallback; an absent config now yields an empty list instead of a second copy that can drift.v2_asset_map.jsfrom the rebuilt frontend.How verified
npm run build(tsc --noEmit + vite + budget) — passednpm run test:operations— passednode tests/console_strategy_execution_validation.mjs— passed (new alias/unmatched assertions)node tests/strategy_switch_worker_validation.mjs— passed (new alias DCA assertions)node tests/console_v2_assets_validation.mjs,console_display_gaps_validation.mjs,console_gap_contract_validation.mjs,console_api_worker_validation.mjs,website_strategy_freshness_validation.mjs— passedpython3 -m unittest discover -s python/tests— 11 failures, all pre-existingtest_checkout_internal_dependency_consumersfailures caused by macOS bash lackingmapfile; digest aggregator tests all pass.