Repository navigation
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The P1 hosted engineering-review draft currently stages only repository Release assets. This stacked draft adds an optional GCS source for approved private input bundles without using a server directory.
HOSTED_INPUT_FETCH_ENABLEDdefaults off. When enabled on main on a GitHub-hosted runner, fetch exactly one pinned object generation, validate metadata/size/SHA256, and reuse existing safe ZIP extraction. Reject wildcards, oversized inputs, stale destinations and digest errors; never fall back after a cloud failure.TRADING_DIFF: No order execution, broker configuration, strategy limits, release or deployment behavior changes. If separately enabled after approval, the review input source changes from a Release asset to an immutable GCS object. Failed reads stop the review. No live workflow has been dispatched.
Depends on #674; this PR targets its existing branch and does not modify that branch. Keep both drafts until their distinct runtime prerequisites are accepted.
Validation: 8 fetch tests with 20 subtests; 5 existing offline ZIP-staging cases; actionlint for the review and staging workflows; git diff --check. Cloud fetch, OIDC/WIF admission and business execution are not validated.