Repository navigation
refactor(qpk): prefer semantics+display over mixed annotations - #655
Merged
Merged
Conversation
B06/N05 follow-up after #654: keep ValueTargetExecutionAnnotations as the compat wire aggregate, but make ValueTargetExecutionSemantics + ValueTargetDisplayAnnotations the preferred construction path. - VALUE_TARGET_DISPLAY_FIELD_NAMES as presentation field source of truth - split/resolve helpers; runtime plan accepts semantics=/display= - build_value_target_execution_annotations uses split→merge (equiv) - do not delete mixed fields yet (B03/B12 consumer adoption gate)
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueTargetExecutionAnnotationsas the compat wire aggregate, but makeValueTargetExecutionSemantics+ValueTargetDisplayAnnotationsthe preferred construction path (batch-upgrade-then-remove-compat).VALUE_TARGET_DISPLAY_FIELD_NAMESis the presentation field source of truth.split_value_target_annotation_parts/resolve_value_target_execution_annotations.build_value_target_execution_runtime_planacceptssemantics=+display=(preferred);annotations=remains.build_value_target_execution_annotationsnow split→merge (behavior-equivalent).Out of scope
decision_mapper(forbidden)ValueTargetExecutionAnnotationsTest plan
uv run --with pytest python -m pytest tests/test_value_target_presentation_facade.py tests/test_strategy_contracts.py -q(41 passed)Author: Pigbibi. No CloudAgent.