Repository navigation
fix: configure independent account observation privately - #608
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The independent account observer required a particular repository, project and deployment inventory, preventing reuse by another installation and mixing public code with deployment settings. It now reads project, service, region, target and source binding from protected configuration and checks the actual serving revision, audience and native observation. The heartbeat uses GitHub Secrets for cloud identity and private observation URLs/bindings; fixtures for this path use example deployments.
Private ingress reports
internal_observer_requiredbefore any broker GET or facts POST. Ingress stays restricted; internal collection and live data recovery remain open.Validation: 286 related tests passed, including another repository/project/branch/target without the public manifest, zero-request private-ingress cases, and all affected heartbeat contracts. Locked Ruff 0.15.20, actionlint and diff checks passed. Existing deployment metadata was copied to protected storage with metadata readback; existing protected bindings and broker credentials were preserved. No IAM, Cloud Run ingress, trading, risk or business schedule change.