Repository navigation
fix(execution): preserve submit failure cause and drop dead QPK fallbacks - #606
Merged
Merged
Conversation
…acks - Capture and log the traceback when the broker submit raises, and include the exception type in the unknown-outcome issue detail so operators no longer lose the cause; the exception message stays out of notifications. - Log post-submit hook tracebacks locally while keeping the generic alert. - Remove ImportError compatibility fallbacks for QPK cash_sweep, small_account_compatibility, execution_capabilities, broker_costs and notification_localization, plus obsolete TypeError fallbacks for extra_replacements/shared_wins, all provided by the pinned QPK version. - Add a regression test asserting the unknown-submission alert keeps the exception type without leaking the provider message. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更
execution_port.submit_order抛异常时不再静默丢弃原因：把 traceback 打印到执行日志，并在broker_outcome_unknown_reconciliation_required通知中附带异常类型（如TimeoutError）。异常消息本身仍只留在本地日志，避免把 broker/provider 内部细节送进通知渠道（沿用现有synthetic-private-*隐私测试的约束）。ImportError兼容回退（cash_sweep、small_account_compatibility、execution_capabilities、broker_costs、notification_localization），以及 renderers/telegram 中针对旧版 QPK 的TypeError回退：当前 pin350dd38e已全部提供。共 -314 行。验证
.worktrees路径污染）全量：2162 passed, 3 skipped，含新增测试。ruff check --exclude external .：All checks passed。说明：在实际的嵌套
.worktrees/code-health-lb-submit-cause路径下直接跑全量会出现 3 个与本改动无关的失败。原因是tests/test_account_new_risk_gate.py依据ROOT.parent.name == ".worktrees"把../QuantPlatformKit/src插入sys.path，该目录下存在quant_platform_kit.egg-info但无direct_url.json，导致importlib.metadata读到无元数据的发行版。该测试文件在改动前后行为一致，CI 的普通 checkout 不触发；已用同一 pin 的干净 worktree 验证通过。不涉及部署。
🤖 Generated with Claude Code