Repository navigation
Fix archived notification events after runtime report finalization - #601
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime report finalization recursively omits null fields from a saved notification event. Archive intake then compared that event with the full canonical dictionary and rejected healthy finalized runs.
Normalize omissions only for the five nullable event payload fields when the canonical value is None. Keep exact identity, run, time, nonempty content and key checks, and reject event counts that contradict the run summary. No serializer, trading dependency, flag, target state or trading path changes.
Validation: the real composer, reporting start_run, strategy summary, pinned QPK finalizer and archive producer feed the offline QRS receiver at bd3dc79f10b2c0b8048721695885c3f9333a53c6, including its final aggregator/receipt. 42 new regression cases cover healthy runs, known zero, proved idle, unknown, urgent paths, duplicates, strict negative cases, heartbeat and uncertain boolean ACKs. Also passed 76 existing notification regressions and repository Ruff checks locally, with network including loopback denied. QRS copies are test-only and have recorded source hashes.
Draft for independent review. Local historical-base candidates are separate, unpublished artifacts. Existing production evidence blockers remain; this change does not authorize deployment.