Repository navigation
[notif-consolidate-1230] LongBridge: default-off target-bound notification consolidation - #600
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LongBridge routine cycles and execution-report heartbeat can now produce target-bound daily candidates behind
LONGBRIDGE_UNIFIED_NOTIFICATION_ENABLED(unset/empty/invalid => false). The boolean selects the existingQSL_ROUTINE_NOTIFICATION_MODE; the original flags-OFF path and historical mode behavior remain intact. Real orders/fills remain immediate, including candidate-store failure; the new routing path usesQSL_DIGEST_ROUTINE_ORDERS=falseand does not defer real-order notifications even if the legacy order setting is true.The producer writes the existing
qsl.digest_candidates.v1payload only after preserving private event/run facts in notification storage. PAPER/HK/SG bindings include target/account/strategy identity and matrix checks. Multiple producers share actual source run IDs. Actual order/fill collections absent fromExecutionCycleResultstay unknown instead of being counted from logs. Healthy runs provide coverage; proved idle windows do not invent runs.Immediate errors, receipt problems, risk escalation and unknown order status reserve conditional GCS markers before sending. Repeated unresolved observations, cold starts and uncertain ACKs do not send again; proved recovery and new severity/reason transitions can alert again. Missing/incomplete marker history fails closed and is recorded as notification failure. Receipt acceptance, due-time/quiet-report rules, trading schedules, disabled targets, broker calls and order/risk/allocation logic are unchanged. PAPER canary stays manual and was not run.
QPK dependency: existing notification-only source snapshot convention. Exact
unified_contract.pyfromQuantStrategyLab/QuantPlatformKitdraft commit60a30ff9a5abc8654787095c9d5a003485afb325, SHA2567ba48d1d7c74e66be8cd3ff983c2117002776e82cda6675a084cfe0dc51aecc0. The trading URL pin remains350dd38ece0952beef096893a7dcf8ae3871609a; all strategy pins/lock files remain unchanged. A full QPK repin would import 140 files of unrelated auth, runtime-control, execution-presentation and research changes, so it was avoided. must be re-pinned to merged/released QPK before merge. No LongBridge A-fix was assigned; new display uses existing localized QPK templates and shared display-name configuration.Validation:
Limitations: production revision/enablement/delivery are unknown; no runtime or channel was invoked. ON adoption needs protected per-target candidate/marker configuration and central receiver acceptance. Old candidate objects without matching private run history are not overwritten. Pending/uncertain claims need operational reconciliation. Legacy unstructured issue categories use fixed-title fingerprints; semantic correlation across different legacy titles remains unknown. Existing coverage configuration targets absent
srcand reports no coverage data; test assertions still run.DRAFT: trading-path sensitive; independent trading-diff review is still required. No merge or ready-for-review in this batch. No deploy, variables/secrets/IAM changes, workflow dispatch/rerun, canary, real sends or broker operations were performed. Needs deploy/runtime and workflow adoption to take effect; not done.
Exact-head CI: SUCCESS on
cffc3b35db84c6ba1d08eb993752280862bf689c, CI run 39004664627, including lint, dependency/lock checks, bounded workflow shell cases and the full unit suite. PR remains DRAFT.