Repository navigation
Classify account snapshot absence and malformed fields with fixed codes - #621
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing account-facts diagnostic can now distinguish an absent snapshot from malformed summary/facts, schema, or currency fields using one fixed
snapshot_issueenum. Classification reads the same in-memory report and only runs after the existing scope and snapshot stages permit it; unknown remains unknown andnonemeans only the original schema/USD predicates passed.The original eight stages, revision expectation, projector, report selection, cloud reads and CLI rejection gate are preserved. The field identifies input shape without inferring a producer cause, synthesizing facts, converting currency, selecting older reports, or exposing private values and report error text.
Validation: 190 focused cases (all original 154 plus 36 new), full suite 1,773 passed with 5 existing skips and 5 existing warnings; frozen sync, Ruff, pin/lock/startup, all-workflow actionlint with ShellCheck, diff and isolated inert probe passed. Root and independent review verify the three-file scope, exact old test prefix and unchanged original stage/main/publisher/workflow functions. Final PR/main CI and the existing authorized main read-only workflow will be recorded in QuantRuntimeSettings #632/#634.