Repository navigation
Conversation
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex; model identifier is not exposed by this execution interface.
What changed
Use one fixed P10 error body for Firstrade cycle errors, HTTP failures, receipt checks (flag on/off), candidate coverage failures and runtime guard errors. Stop rendering errors as healthy heartbeats or no-rebalance results. Retain unknown submission/pending state, preserve the structured fractional-disclosure action, and exclude raw aliases, provider diagnostics and untrusted links.
Normal cycles still persist through the existing digest-candidate path. Existing incident reservations, restart/uncertain-delivery handling, broker calls and execution protections are preserved. Notification-only fake snapshots cover both languages; the historical broker/state golden remains exact. The golden test now replaces the missing GCS store explicitly, avoiding credential discovery.
How verified
Why
Step 6 of the owner-approved eight-repository notification plan requires real errors to share the fixed format without turning HTTP 503, missing evidence or unknown orders into health claims.
Risk
Notification presentation only. No workflow, dependency, vendor snapshot, execution gate, protected switch or production configuration change. No merge, deploy, labels or real notifications. Runtime/deployed acceptance and authentic delivery remain NOT_PROVEN.
Step-1 pin follow-up: the notification-unification QPK Draft PR was not yet published at implementation/readback time. This consumer implements the approved plan's presentation contract using its existing shared redaction dependency. Replace the local presentation implementation with the published shared formatter and pin its reviewed revision when available; this PR does not claim shared-formatter deployment/adoption. Arbitrary strategy aliases remain unverified rather than echoed.
Central publication check
publication-check/2.0-advisory, build 83d9d1130377: 1169 matches across 115 files; 1164 matching lines; advisory exit 0.
The scanner is advisory under the owner rule. Matches include existing tracked references and <PROJECT_ID> test inputs; this patch does not perform a repository-wide cleanup. First 20 masked locations/texts: