Skip to content

refactor: isolate lifecycle execution record projection #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pigbibi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: isolate lifecycle execution record projection #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions application/rebalance_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,23 @@ def _unsupported_strategy_execution_result(
)


def _build_platform_execution_record(result, *, settings):
return {
"platform": "firstrade",
"action_done": result.get("action_done"),
"broker_submission_done": result.get("broker_submission_done"),
"execution_status": result.get("execution_status"),
"orders_pending_count": result.get("orders_pending_count"),
"strategy_run_stage": result.get("strategy_run_stage"),
"dry_run_only": settings.dry_run_only,
"submitted_orders": result.get("submitted_orders"),
"skipped_orders": result.get("skipped_orders"),
"error": result.get("error"),
"total_equity": (result.get("portfolio") or {}).get("total_equity")
or (result.get("portfolio") or {}).get("equity"),
}


def run_strategy_cycle(
*,
runtime_settings: PlatformRuntimeSettings | None = None,
Expand Down Expand Up @@ -1007,19 +1024,6 @@ def acquire_submission_claim() -> bool:
result["notification_suppressed"] = True
try_record_platform_execution(
strategy_runtime.profile,
{
"platform": "firstrade",
"action_done": result.get("action_done"),
"broker_submission_done": result.get("broker_submission_done"),
"execution_status": result.get("execution_status"),
"orders_pending_count": result.get("orders_pending_count"),
"strategy_run_stage": result.get("strategy_run_stage"),
"dry_run_only": settings.dry_run_only,
"submitted_orders": result.get("submitted_orders"),
"skipped_orders": result.get("skipped_orders"),
"error": result.get("error"),
"total_equity": (result.get("portfolio") or {}).get("total_equity")
or (result.get("portfolio") or {}).get("equity"),
},
_build_platform_execution_record(result, settings=settings),
)
return result
Loading
Loading