Repository navigation
fix: Handle empty archive months in heartbeat publishing - #512
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Pigbibi
marked this pull request as ready for review
November 2, 2026 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix heartbeat candidate publication when a completed business window spans two UTC months and one archive partition has no matching objects. Move the existing prepublication Storage SDK reader into the archive module and reuse it for heartbeat reads. Successful empty listings reach the existing schedule check; permission, timeout and malformed JSON failures still abort. Missing due reports remain failures.
Keep bounded reads, generation-pinned downloads and existing candidate merge/write behavior. Add synthetic cross-month tests for empty partitions, unrelated reports, preserved executed reports and failed paginated reads.
Verification
Risk: ordinary notification code. Storage behavior is verified offline with synthetic clients; production publication and deployment were not exercised. An uncertain write still requires inspection before any retry.
AI assistance
Authored with OpenAI Codex (GPT-6.1 Sol). A separate Codex agent reviewed the complete four-file change and relevant callers at the submitted head, including SDK empty-list semantics, schedule guards and failure propagation. Review evidence is retained outside Git. This draft does not authorize deployment or operational actions.