Repository navigation
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex (GPT-6). Scope: source/workflow changes and local validation. Independent review is pending.
What changed
Pin the merged QPK safety commit with existing dependency/qsl/lock pins. Replace custom sends with
QPK intent or existing explicit-credential compatibility transport; install entrypoint redaction
and add report serialization coverage. Preserve historical goldens, adjusting only expected
removal of raw technical diagnostics under the new QPK privacy contract. Degraded/unknown status
remains visible.
How verified
Full suite: 1713 passed with one stale raw-diagnostic expectation. All 73 related notification,
equivalence and serialization cases passed after updating that expectation; all original control-
call comparisons remain. Ruff, lock, documentation and diff checks passed. Test fixtures and
delivery clients are synthetic; no secret payload, live account, Telegram or cloud write was used.
Why
Credential-bearing notification parameters and runtime output must not enter public run reports or
Git data branches.
Risk
High: runtime SDK and notifications. Raw technical diagnostic prose now stays in source logs and
messages retain the localized diagnostic pointer. In-memory SecretStore credentials keep shared
compatibility transport. No broker, risk, authority, route, settings, label or deployment changes.