Skip to content

fix: centralize Telegram notification safety and redaction - #505

Draft
Pigbibi wants to merge 1 commit into
mainfrom
fix/notification-intent-safety
Draft

Pigbibi wants to merge 1 commit into
mainfrom
fix/notification-intent-safety

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Codex (GPT-6). Scope: source/workflow changes and local validation. Independent review is pending.

What changed

Pin the merged QPK safety commit with existing dependency/qsl/lock pins. Replace custom sends with
QPK intent or existing explicit-credential compatibility transport; install entrypoint redaction
and add report serialization coverage. Preserve historical goldens, adjusting only expected
removal of raw technical diagnostics under the new QPK privacy contract. Degraded/unknown status
remains visible.

How verified

Full suite: 1713 passed with one stale raw-diagnostic expectation. All 73 related notification,
equivalence and serialization cases passed after updating that expectation; all original control-
call comparisons remain. Ruff, lock, documentation and diff checks passed. Test fixtures and
delivery clients are synthetic; no secret payload, live account, Telegram or cloud write was used.

Why

Credential-bearing notification parameters and runtime output must not enter public run reports or
Git data branches.

Risk

High: runtime SDK and notifications. Raw technical diagnostic prose now stays in source logs and
messages retain the localized diagnostic pointer. In-memory SecretStore credentials keep shared
compatibility transport. No broker, risk, authority, route, settings, label or deployment changes.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant