Skip to content

fix: isolate candidate roots without moving notification markers - #492

Merged
Pigbibi merged 3 commits into
mainfrom
fix/candidate-root-override
Nov 1, 2026
Merged

Pigbibi merged 3 commits into
mainfrom
fix/candidate-root-override

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Codex (GPT-6), with local self-review.

What changed

A private per-target binding can override the heartbeat workflow's candidate URI, leaving writers on an old bucket after a migration. Add the explicit repository variable DIGEST_CANDIDATES_OVERRIDE_GCS_URI, applied after binding resolution. Preserve the original explicit marker root, or its former candidate-root default, so existing incident reservations remain authoritative.

The default remains unchanged. Invalid override roots fail before storage access. Target identity, archive inputs, enablement, trading paths, and central delivery receipts are unchanged. Document single-target configuration and staged migration.

How verified

  • Reproduced the missing override with seven failing regression cases, then passed 100 related storage, notification, publisher, and diagnostic tests.
  • Added the empty-prefix edge case; all 10 scoped-state cases passed.
  • Repository-pinned Ruff, documentation check, and diff check passed (one existing README advisory).
  • Full local pytest suite is running. No deployment, source switch, real notification, or natural-window success is claimed by this PR.

Pigbibi and others added 3 commits November 1, 2026 16:20
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 86e6599e-ce44-48db-98fb-e8be8b5e524d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 1, 2026 — with ChatGPT Codex Connector
@Pigbibi
Pigbibi merged commit 91359fb into main Nov 1, 2026
8 checks passed
@Pigbibi
Pigbibi deleted the fix/candidate-root-override branch November 1, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant