Repository navigation
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Cached-session account-facts failures now identify when the existing manual session-renewal flow is required. Upstream 401 and missing/expired cache still return the existing redacted HTTP 503 response: no automatic login, retry, cache mutation, or snapshot publication is added.
Candidate publication previously collapsed persistence failures into an opaque storage alert. Add allowlisted stage/reason diagnostics for binding, storage initialization, archive reads, projection, candidate history/merge, serialization and writes. Pass the same localized diagnostic through the healthy-heartbeat coverage alert so its acknowledgement marker cannot hide the stage behind an earlier generic message. Keep alert deduplication, generation preconditions and bounded explicit-conflict handling; do not retry uncertain writes.
Offline coverage confirms that an initial candidate NOT_FOUND already follows the correct create-only path. The incident's precise persistence defect is still unknown; this PR does not infer an IAM defect or redesign/replay projection.
How verified
Follow-up and limits
Actual session renewal and account-facts refresh remain unexecuted. The existing generic invocation workflow can create/update Scheduler bridges; any operational recovery must preserve the requested no-configuration-change boundary. Snapshot refresh also writes to the existing receiver, so it requires resolution of the stated QuantRuntimeSettings boundary.
Obtain the new safe failure stage/category through an approved adoption and observation before changing the persistence path further. Read back uncertain write outcomes before any separately authorized retry. No changes to QuantRuntimeSettings, IAM, credentials, schedules, runtime enablement or trading controls; no candidate re-projection, live trade or real notification.
AI assistance
OpenAI Codex (GPT-6 family). No delegated agents.