Repository navigation
fix: preserve snapshot http failures and resolve digest binding - #483
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
added
the
owner-approved
Preserve heartbeat identity and publication-before-read documentation. Retain governance and runtime changes from main without rewriting history. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex (GPT-6) prepared this change and its offline regression checks.
What changed
Preserve the exact allowlisted Cloud Run HTTP failure from snapshot completion evidence instead of collapsing HTTP 503 into a combined authentication/provider error. A failed request cannot be erased by a separate success, and unknown outcomes are never retried. Snapshot gcloud calls now name the existing workflow account explicitly.
Heartbeat and completed-window projection also gain an in-memory fallback for missing single-target digest identity/slot settings. It reads only the sole 100% serving revision after matching the configured runtime identity; conflicts, missing values and split/changing traffic fail closed. It does not dereference Secret Manager references or invent identities.
The historical 503's internal application cause is still unproven. The separate alerting secret-access denial needs a written, secret-scoped IAM request outside this PR. No permission, secret, variable, binding, scheduler or deployment change is included.
How verified