Repository navigation
refactor(notifications): import pinned QPK digest modules - #423
Merged
Merged
Conversation
Delete the vendored notification snapshot (notifications/digest_snapshot/) and notifications/display_names.py. All five modules are byte-identical to the modules at the pinned quant-platform-kit revision, so production code, scripts and tests now import them from quant_platform_kit directly. Drop the snapshot provenance hash test; the QPK pin is the single reviewed source. Update docs/unified-daily-notification.md. QPK/strategy pins, trading, deployment and CI configuration are unchanged. Verification: baseline 1064 passed; after 1063 passed (one provenance test removed), 0 failed, 0 skipped; targeted notification tests 122 passed; ruff check . passes. Co-Authored-By: Claude Code <noreply@anthropic.com>
Record that display name resolution comes from quant_platform_kit.common.display_names installed with QPK pin 5181f2d6, that the local notifications/display_names.py/json copies were removed, and that the notification modules come from the same QPK pin. Documentation only; no code or configuration change. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quant-platform-kitrevision5181f2d6a44b935f7b82c46bc9e77439297e18d5(verified byte-identical by sha256).notifications/digest_snapshot/(digest_archive.py,digest_candidates.py,digest_routing.py,unified_contract.py,__init__.py,provenance.json) andnotifications/display_names.pyplus its now-unreferencednotifications/display_names.jsondata file.quant_platform_kit.notifications.*andquant_platform_kit.common.display_names, keeping the same imported names.test_qpk_snapshot_matches_recorded_source_hashes: the vendored snapshot it guarded is removed, and the QPK pin is now the single reviewed source.docs/unified-daily-notification.mdto state that these modules are imported from the pinned QPK dependency and no longer vendored.Behavior
No business logic, function signatures, exception text or data structures changed. QPK pin (
pyproject.toml/uv.lock), CI workflows, deployment configuration and funding paths are untouched.Verification
uv run pytest -q tests: 1064 passed, 0 failed, 0 skipped.uv run ruff check .: All checks passed.🤖 Generated with Claude Code