Repository navigation
feat(runtime-guard): NOTIFY-04 B5 alert de-duplication (dry_run by default) - #410
Merged
Merged
Conversation
…fault Same failure entries are re-reported by up to six 30-min runs (180-min lookback). New entries / new issue types always alert; pure repeats are suppressed only in mode=on (re-alert after 6h). Workflow default mode=dry_run logs would_suppress and never suppresses. State: hashes + timestamps via actions/cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTIFY-04 B5 — runtime-guard alert de-duplication (dry-run by default)
Why.
runtime-guard.ymlruns every 30 min with a 180-min log lookback. One Cloud Run / Scheduler failure entry is re-reported by up to six consecutive runs, and the guard had no de-duplication.What.
scripts/runtime_guard_alert_dedupe.py(identical in Schwab / IBKR / LongBridge / Firstrade):insertId, hashed) → always alert.RUNTIME_GUARD_ALERT_DEDUPE_REMINDER_HOURS(default 6).actions/cacherestore/save.RUNTIME_GUARD_ALERT_DEDUPE_MODE:off|dry_run|on. The workflow default isdry_run: it never suppresses, it only logsruntime_guard_dedupe … would_suppress=true|falseso the effect can be observed. The script default when unset isoff.on(NOTIFY-04 B7, separate approval).Tests:
tests/test_runtime_guard_alert_dedupe.py(off/dry_run/on, new entry, new issue type, count-only change, reminder, recovery, hashes-only state, pruning); existingtest_cloud_run_runtime_guard.pystill passes.