Repository navigation
refactor(b12): decision_mapper → QPK semantics/display facade (parity-tested) - #409
Merged
Merged
Conversation
- decision_mapper builds ValueTargetExecutionSemantics + ValueTargetDisplayAnnotations and calls build_value_target_execution_runtime_plan(semantics=, display=) - no more build_value_target_runtime_plan / mixed ValueTargetExecutionAnnotations - bump QPK pin 350dd38 -> 155d74a (same pin as Schwab/Binance) for the facade - parity: golden plans generated on main@a314852 + QPK@350dd38 (legacy path); new path reproduces them exactly, and matches QPK compat facade per case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (B12 consumer batch — Firstrade)
decision_mapper.pynow buildsValueTargetExecutionSemantics+ValueTargetDisplayAnnotationsand callsbuild_value_target_execution_runtime_plan(semantics=, display=)(QPK #654/#655).build_value_target_runtime_plan, mixedValueTargetExecutionAnnotations(...)andbuild_value_target_execution_annotations.350dd38→155d74a(same pin Schwab / Binance already run). The facade does not exist at350dd38.Behavior parity
tests/fixtures/value_target_plan_parity.json(9 cases: full/legacy-key annotations, default threshold, weight translation incl. cash-only off, zero-equity block with/without holdings,no_execute, reserved-cash policy cap, risk-control execution fields,cash_by_currency) were generated on main@a314852 + QPK@350dd38 (legacy path).df0420c1…e896before and after).../QuantPlatformKit/srchidden).QPK delta 350dd38..155d74a reviewed for Firstrade
common/execution_translation.py,strategy_contracts.py,presentation/*: facade split; legacy path delegates (covered by parity above).longbridge/auth.py(#653): not imported by Firstrade.strategy_lifecycleAI/watch/research modules: not imported (FT uses onlyperformance_monitor,live_equity, unchanged).execution_kernel(#657): new, unused.Not in scope
No deploy / env / secret / traffic change. No Firstrade sync/session/claim/ingress change. Deploys remain manual
workflow_dispatch; last 15 main commits show only github-actions checks (no Cloud Build app).Author: Pigbibi.