Repository navigation
fix(notify): prefer injected unified Telegram token over firstrade-telegram-token - #404
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
2026-10-09 decision: all quant notifications go through the unified bot QSL资产管家 (
quant-sentinel-telegram-bot-token). NOTIFY-01 audit found Firstrade still read Secret Managerfirstrade-telegram-tokenfirst inmain._get_telegram_token()(runtime error alerts), with the injectedTELEGRAM_TOKENonly as an exception fallback.Change
runtime_config_support.resolve_telegram_token()order:TELEGRAM_TOKEN(Cloud Run secret ref, synced from repo varTELEGRAM_TOKEN_SECRET_NAME=quant-sentinel-telegram-bot-token)TELEGRAM_TOKEN_SECRET_NAME, if setfirstrade-telegram-token— last fallback onlymain._get_telegram_token()andPlatformRuntimeSettings.tg_tokenboth use it (blank env values no longer short-circuit to an empty token).tests/test_telegram_token_resolution.py.No strategy / execution / env / IAM changes.
Test
pytest -q→ 830 passed