Repository navigation
fix(afs): fall back to available_cash when cash_balance absent - #403
Merged
Merged
Conversation
When equity is present but the broker omits cash_balance, publish the exact available_cash figure as cash so the console cash column is not empty. Still never synthesize cash from equity or buying power.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Firstrade returns equity but omits
cash_balance, publish exactavailable_cashas AFS cash so the console cash column is not empty while assets are present.Still never synthesizes cash from equity or buying power.
SiYi click
Test
pytest tests/test_account_facts_publisher.py(37 passed)