Repository navigation
Default missing Firstrade AFS balance currency to USD - #395
Merged
Merged
Conversation
After sole-account fallback, snapshot build failed with provider_currency_unavailable because Firstrade balance payloads omit an ISO currency field. Match runtime_broker_adapters and treat omitted currency as USD while still rejecting invalid codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After sole-account fallback,
/account-facts-syncfailed at snapshot build withprovider_currency_unavailable. Firstrade balance payloads omit ISO currency; the rest of this platform already treats Firstrade as USD.USDinbuild_firstrade_account_snapshotNo trading-mode / strategy change.