Repository navigation
Normalize Firstrade account IDs for account-facts-sync match - #393
Merged
Merged
Conversation
Cloud Run /account-facts-sync was past auth but returned account_identity_mismatch. Coerce SDK account numbers (and balances map keys) to strings so int JSON values match the runtime_target selector, split empty-list failures, and log a masked expected account on collect errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After auth was fixed,
/account-facts-syncreturned HTTP 503 withaccount_identity_mismatch(collect path). Probe/session reuse is healthy.Likely cause: Firstrade SDK can leave
account_numbersas JSON ints whileruntime_target.account_selectoris a string, so membership checks fail.Changes:
FirstradeBrokerClientaccount_list_emptyNo trading-mode / strategy change.