Repository navigation
fix: align evidence review roles and gate AI release readiness - #268
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
marked this pull request as ready for review
October 14, 2026 18:20
…tract-ready-20261015 Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drift review config uses primary/secondary/verification, while the PR Evidence Gate requests incompatible reviewer-* labels. Use the same role contract and pass AI_SERVICE_RELEASE_READY to the Evidence Gate. Promotion review rejects missing/false/invalid readiness before dispatch, including when the legacy skip flag is set. Nonpromotion changes still need no AI.
Document the current readback: readiness is false, and all three roles route to configured-dot. Different role/profile labels do not satisfy independent review. This draft changes no variables, grants, IAM, deployments, or trading logic.
Validation: 23 focused regression tests passed; actionlint passed for evidence-gate.yml. Owner authorized final safety review and squash merge after all checks pass.
Follow-up safety review: no permission expansion or trading/configuration changes. Focused tests passed; CI must remain green. No paid model call or server access was used.