Repository navigation
Preserve the selected Schwab TCP probe in notification revision plans - #540
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selected Schwab revision
charles-schwab-quant-service-00781-leluses a TCP startup probe. The offline notification revision planner currently requires the HTTP probe, so it cannot represent a candidate that preserves this baseline exactly.Add an explicit
schwab-00781-tcp-preservepolicy to the existing planner and share structural inventory checks with the existing verifier. The default HTTP policy and verifier CLI behavior remain unchanged. The TCP policy requires the exact selected identity, old image, source declarations and complete probe, then applies the existing before/current/candidate, UID/resourceVersion, traffic/tag and full configuration guards. TCP assurance is explicitly limited to port readiness.scripts/verify_cloud_run_no_traffic_deploy.pyscripts/build_schwab_notification_revision_plan.pytests/test_verify_cloud_run_no_traffic_deploy.pytests/test_build_schwab_notification_revision_plan.pyValidation on head
27628475034a6b78806de156d8a96c297371237d:This PR covers the existing offline declaration model only. It does not wire the real publisher or native Cloud Run Service renderer, prove cloud origin or a live resourceVersion conditional update, or verify runtime startup, HTTP health or notification bindings. The planner continues to report
deployment_ready=false. Existing deployment startup checks remain unchanged. No production image build, deployment, collector, notification switch or dependency pin change is included.