Repository navigation
Add local notification candidate review-plan builder - #539
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewing a notification-only candidate currently requires reasoning about which fields may differ from an explicitly selected baseline. Add a pure local builder and tests that require matching caller-supplied snapshots, preserve protected fields and routes, and allow only the explicit revision identity and primary image digest to differ.
The CLI reads an explicitly supplied synthetic
schwab-local-review-v1envelope and returns deterministic, redacted review JSON. Unknown fields, snapshot drift, invalid protected runtime settings and unexpected candidate differences stop the review. It reuses the applicable pure A validators without manufacturing provenance or calling the full admission check.Scope is exactly two new files:
scripts/build_schwab_notification_revision_plan.pytests/test_build_schwab_notification_revision_plan.pyIndependent review at
1fb1cafa14c5d2f1e8e7c0a34a225b9cd5c3a737, treea0fc106ed5f8af995029466e393889990ea982ad: PASS_WITH_NOTES, no confirmed blocking defect. Reviewer ran the original B suite (237 passed), original A suite (286 passed), Ruff, 38 additional synthetic checks and a direct script invocation without PYTHONPATH. Original disk CLI tests remain intact; external fake executable calls were zero. All 258 pre-existing tracked file blobs and modes remain unchanged, including workflows, manifests and business configuration.The notes describe the intended boundary: this closed synthetic model is not a native Cloud Run resource, environment literals remain opaque, and caller-provided snapshot consistency is not live CAS or cloud/source/admission proof. Output stays
review_only,deployment_ready=false,old_installation=UNKNOWN, andstartup_side_effects=UNVERIFIED. No deployable configuration or execution script is emitted. No publisher wiring, deployment workflow, dependency pin, runtime setting, notification/trading flag, permission or Secret change is included.Validation also requires the existing natural PR CI and, after an exact-head squash merge, the natural main CI. This code does not authorize or perform a production deployment.