Repository navigation
chore: remove the shadow governance observer - #47
Merged
Merged
Conversation
The observer existed to answer one question: whether the repository should switch to the reconciled verifier. That verifier could not converge, both governance repositories returned to the canonical gate, and the question is settled. Its snapshot check also treats any comment or body change during a read as stale evidence, so it fails whenever a review starts while it runs. It is report-only, so the result is a red cross on pull requests that blocks nothing and teaches readers to ignore a red check. Remove the reusable engine, its tests, the policy document it reads and the documentation that describes it.
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
marked this pull request as ready for review
November 5, 2026 19:29
Pigbibi
added
the
agent-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Qoder agent (DeepSeek) located the observer and its callers, wrote the change and ran the local checks. Codex reviews through the repository integration.
What changed
Removes the report-only governance observer that this repository hosted for other repositories to call:
.github/workflows/governance-acceptance.yml— the reusable shadow engine..github/workflows/governance-shadow-tests.ymlandscripts/test-governance-shadow.cjs— its tests..github/governance/policy.json— the policy document it read at a pinned revision.docs/governance-shadow.md, plus the README links in both languages.PROPOSAL.mdkeeps its text as a historical record; the superseded note now says the observer and its tests are gone.The observer existed to answer one question: whether the organization should switch to the reconciled verifier. That verifier could not converge, both governance repositories returned to the canonical gate, and every gate-carrying repository is being unified on that file. Nothing consumes the answer now.
It also reported
READ_OR_INTEGRITY_FAILUREwhenever a comment or body change landed during its read window, which is exactly when a review is starting, so it produced a red cross on pull requests while blocking nothing.The canonical gate is untouched. It does not read
governance/policy.json: that path only appears in its high-risk classifier, which stays.How verified
grepover this repository finds no remaining caller ofgovernance-acceptance.ymlorscripts/test-governance-shadow.cjs; the twoPROPOSAL.mdreferences are historical and now labelled as such.QuantAIServiceandQuantAdvisorResearch. Both pinned the engine ata267ab46, which still exists, so neither is broken before its own change lands..github/workflows/risk-gate.ymlis unchanged; this pull request does not touch the gate.Why
Deleting a dead report-only path is smaller and safer than repairing its snapshot race, and it stops the red cross that trained readers to ignore a red check.
Risk
High-risk by path, because it removes files under
.github/workflows/; it needsagent-approvedafter review. Behavioural risk is low: nothing in the merge path consumes these files, and both consumers lose their call in their own reviewed pull requests.