Skip to content

Make the random-name test independent of duplicate draws #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quantconnect-kronos merged 1 commit into from
Nov 13, 2026
+9 −1
Merged

Make the random-name test independent of duplicate draws #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/components/util/test_name_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from unittest import mock

from lean.components.util.name_generator import NameGenerator


Expand All @@ -23,5 +25,11 @@ def test_generate_name_generates_names_with_at_least_three_words() -> None:

def test_generate_name_generates_names_randomly() -> None:
name_generator = NameGenerator()
draws = ["Calm", "Blue", "Fox", "Geeky", "Red", "Owl"]

with mock.patch("random.choice", side_effect=draws) as choice:
assert name_generator.generate_name() == "Calm Blue Fox"
assert name_generator.generate_name() == "Geeky Red Owl"

assert name_generator.generate_name() != name_generator.generate_name()
assert choice.call_count == len(draws)
assert all(draw in call.args[0] for call, draw in zip(choice.call_args_list, draws))
Loading