Repository navigation
Keep the first history point of a canonical download - #21
Merged
Merged
Conversation
IQFeedDataDownloader.GetCanonicalSymbolHistory called Any() on the consuming enumerable of its BlockingCollection, which removed the first history point and dropped it. Return Lean's GetConsumingEnumerableOrNull() instead: null when no contract returned history, otherwise every point, the first one included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IQFeedDataDownloader.GetCanonicalSymbolHistorycalledAny()on theBlockingCollection's consuming enumerable, which removed the first history point and dropped it. It now returns Lean'sGetConsumingEnumerableOrNull()(QuantConnect/Lean#10100):nullwhen no contract returned history, otherwise every point, the first one included.Related Issue
Closes #20
Motivation and Context
Every non-empty canonical download lost one history point, and a download with a single point returned an empty, non-null result.
Requires Documentation Change
No.
How Has This Been Tested?
2.5.*package references resolve to it, so no project file changes.dotnet teston the test assembly, as CI runs it: 4 failed, 1 skipped. The same 4LookUpSymbolstests fail onmasterhere: theirOneTimeSetUpvalidates a QuantConnect subscription ("Invalid api user id or token"), and I had no credentials locally.[Explicit]fixture that needs IQFeed credentials. No offline regression test was added either, because the per-contract history comes fromIQFeedFileHistoryProviderdirectly and can't be stubbed without changing the downloader.nullwhen there are none, and a producer that adds items later.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>🤖 Generated with Claude Code