-
-
Notifications
You must be signed in to change notification settings - Fork 491
fix(invite): guard against None code #3313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmphase
wants to merge
17
commits into
master
Choose a base branch
from
fix/invite-optional-code
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−33
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
bbb8e45
fix(invite): guard against None code
vmphase 2bd7ace
chore: update changelog
vmphase 43af42c
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ed05041
fix(invite): return "" on id property when code is None
vmphase d348ffc
refactor(types/invite): do not inherit VanityInvite from _InviteMetadata
vmphase 70099ec
fix(invite): raise ValueError when code is None
vmphase 6a5cfa1
refactor(types/invite): inline _InviteMetadata into IncompleteInvite
vmphase 1812204
chore: update changelog
vmphase bc00082
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6b657a8
Merge branch 'master' into fix/invite-optional-code
vmphase a665bcf
chore: simplify changelog
vmphase a1c109e
fix(invite): preserve `__str__` return value for invites with a code
vmphase 5a04ef4
Merge branch 'master' into fix/invite-optional-code
vmphase 442ccbc
feat(invite): deprecate Invite.id
vmphase c921a59
chore: fix changelog
vmphase 7ab228a
feat(invite; guild): revert guards, cast data to IncompleteInvite
vmphase 6a51a9b
chore: update changelog
vmphase File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.