Repository navigation
Pyodide gallery: Open in Workbench - #221
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pyodide demo page gets the button the MicroPython gallery has: under the screen, beside Show console, opening the example in Workbench in a new tab (the demo keeps running in the gallery's frame).
Workbench's simulator is MicroPython and takes its examples from the MicroPython gallery's file list, so the button shows only for an example that list has (
<name>.pyor a<name>/package); a Pyodide-only example gets none. The page's stylesheet version moves to 7 so the button's style isn't served from an old cache.Checked in Chromium on the page served locally:
?modules=piano&deps=…shows the button linking toworkbench/?vm=1&example=pianowithtarget=_blank; an unknown name and the bare page show none.