Repository navigation
put -r from WSL: the Windows sidecar opens /mnt/<drive> paths - #120
Merged
Merged
Conversation
A recursive put handed the sidecar the path the CLI resolved, which under WSL is /mnt/c/...; the sidecar runs under Windows Python and answered "local path not found" for a folder that exists. It now tries the Windows spelling of a WSL mount path before giving up, and walks that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under WSL,
mpftp put -r /mnt/c/.../folder /destfailed with "local path not found" for a folder that exists: the CLI passed its resolved path to the sidecar, which runs under Windows Python. The sidecar now tries the Windows spelling of a/mnt/<drive>/...path before giving up, and walks that.Tested on an ESP32-S3: a 17-file folder copied and verified, 17 of 17. Unit tests for the path translation added to
cli/tests/test_put.py.