Repository navigation
Pin audiodsp v0.6.10: audiograph builds where mp_float_t is double - #169
Merged
Merged
Conversation
v0.6.9's Graph.get passed a float to mp_obj_new_float, which a double-float build (the webassembly port) refuses under -Werror=double-promotion. v0.6.10 casts it; nothing else moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audiodsp v0.6.9 doesn't build for the webassembly port:
audiograph'sGraph.getpassed afloattomp_obj_new_float, and a double-float build refuses that under-Werror=double-promotion. v0.6.10 (d2c502b) adds the cast (audiodsp#308). Past v0.6.9 there's nothing else but the release commit. None of this repository's jobs build the webassembly port, which is why #168 passed.