This repository was archived by the owner on Oct 19, 2026. It is now read-only.
Repository navigation
Conversation
CircuitPython 11 reads USER_C_MODULES like MicroPython 1.29 does, so the same micropython.mk builds usdl2 into its unix port with no change to CircuitPython's own tree. usdl2_mp.c registers the module when built that way (CIRCUITPY is 1 on CircuitPython's unix port, so it used to skip its MP_REGISTER_MODULE). On any other CircuitPython port the module refuses to build: boards there use CircuitPython's displayio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircuitPython 11 builds user C modules through
USER_C_MODULESthe way MicroPython 1.29 does, somicropython.mknow buildsusdl2into CircuitPython's unix port directly:usdl2_mp.cregisters the module under that build (DISPLAYIF_USER_C_MODULE, passed bymicropython.mk). CircuitPython's unix port setsCIRCUITPY=1, so before this it skippedMP_REGISTER_MODULE.displayio, and displayif's display modules aren't ported to it.apply_cp_patches.shstill works for a tree patched the older way.Checked on CircuitPython 11.0.0-alpha.1 unix (coverage):
tools/test_usdl2.pypasses underSDL_VIDEODRIVER=dummy, and a real X11 window opened and drew (captured from the X server, pixels exact). A build without this module fails the same test withImportError.