This repository was archived by the owner on Oct 19, 2026. It is now read-only.
Repository navigation
jpegio builds without LVGL - #47
Merged
Merged
Conversation
…s modules, not by what's on disk, and includes LVGL through the bindings path lvgl-micropython already exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
displayif's CMake glue turned on jpegio's LVGL decoder whenever an
lvgl-micropythoncheckout existed beside displayif on disk, not when LVGL was in the build. A build of displayif without LVGL therefore linked code callinglv_*, and failed: on an RP2040 withdisplayif,pygraphics,palettes,pdwidgets, 18 undefined references tolv_is_initialized,lv_image_decoder_get_next,lv_fs_readand others. jpegio was split out of LVGL to be usable without it.USER_C_MODULES, the way the make glue already did.-DJPEGIO_LVGL=ON/OFFstill overrides.lvgl_decoder.cincludeslvgl/lvgl.handlvgl/src/…. Those resolve through the bindings path lvgl-micropython already exports, so neither glue derives a bindings path of its own. That path was wrong whenever lvgl-micropython uses its own fetched bindings (PyDevices/lvgl-micropython, fetch_bindings.sh).Proven 2026-10-05: unix
displayif,pygraphicsbuilds. The RP2040 set above now links. Unix withdisplayif,lvgl-micropython(decoder forced on) compiles the decoder against fetched bindings and importslvglandjpegio. An RP2350 build withdisplayif,lvgl-micropythonbuilds with the decoder on.