Repository navigation
Build: drop cached packages and the dist that no longer match the recipe pins - #24
Merged
Merged
Conversation
…ipe pins p4a keeps older installed package versions beside newer ones and reuses an existing dist, so moving a recipe pin could still package the old version. build_android.sh now prunes mismatched packages and the dist before building, a p4a hook refuses a dist that still differs from the pins, and the build lists only the APK it just made. Same fix as android-runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p4a keeps older installed package versions beside newer ones and reuses an existing dist, so moving a recipe pin could still package the old version. The build now prunes whatever no longer matches
p4a_recipes/before it starts, and a p4a hook fails it if the dist still differs. The build also lists only the APK it just made. This is the same fix android-runner has.Checked with two real builds: with palettes pinned at 0.0.13 the APK carried 0.0.13 only; moving the pin to 0.0.14 and rebuilding pruned the old package and dist, and the new APK carried 0.0.14 only. shellcheck is clean.