Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
length_sort=Trueandsort_order="native",import bbbbbbbbbbis placed beforeimport a. The length prefix in the sort key is compared as text, so multi-digit lengths do not follow numeric order. The same problem affects imported names andforce_sort_within_sections.Zero-pad length prefixes to the width of
sys.maxsizein both module and section keys. This covers the possible range oflen()while keeping the string key interface used by sorting plugins. Natural ordering, equal-length tie breaking, reverse sorting, type groups andforce_to_topretain their behavior.Fixes #2698.
Validation on Windows with Python 3.12.7, against
d93953fa5c9f188db31b9006cb681de1126e5967:python -X utf8 -m coverage run --parallel -m pytest tests/unit -q -ra --tb=short: 693 passed / 5 skipped. The skips are existing platform restrictions and an existing duplicate-import TODO.isort/sorting.py, including branches.git diff --checkpass.--skip example_crlf_file.pyto apply the already-configured fixture exclusion by basename on Windows.--platform linux, matching the lint job's target platform, and for the two changed files with native Windows settings. Native Windows checking of the entire tree reportsos.mkfifoin the unchangedtests/unit/test_settings.pyfixture.