AOT: ReflectionExtension::isPersistent/isTemporary thin proxies (#34154) - #34159
Closed
PurHur wants to merge 1 commit into
Closed
AOT: ReflectionExtension::isPersistent/isTemporary thin proxies (#34154)#34159PurHur wants to merge 1 commit into
PurHur wants to merge 1 commit into
Conversation
Bake loaded-extension names for isPersistent; isTemporary always false (no dl()). Closes #34154. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReflectionExtension::isPersistent()/isTemporary()proxies — ExternalMethod returned NULL.isPersistent(thin AOT__compiler_extension_loadedis 0 underHELPER_RUNTIME_O=0);isTemporaryalways false (nodl()).Context.php; spine requires for Call + Runtime.php-src:
ext/reflection/php_reflection.c—zim_ReflectionExtension_isPersistent/isTemporary.Closes #34154
Test plan
./script/aot-smoke.sh→ 8 passed, 0 failedtest/repro/issue_34154_reflection_extension_ispersistent_aot.php→persistent=1 temporary=0./script/phpunit.sh --filter Issue34154ReflectionExtensionIsPersistentAotTest→ OK (4 tests, 17 assertions)php script/check-selfhost-spine-coverage-sync.php→ OKNot covered: full compliance suite, differential sweep,
ci-fast.sh,north-star5-verify --strict.Made with Cursor