Skip to content

Stdlib: mb_strpos() NestedJIT runtime leftover of #27187 (#34146) - #34153

Merged
PurHur merged 1 commit into
masterfrom
fix/34146-mb-strpos-runtime-aot
Aug 23, 2026
Merged

Stdlib: mb_strpos() NestedJIT runtime leftover of #27187 (#34146)#34153
PurHur merged 1 commit into
masterfrom
fix/34146-mb-strpos-runtime-aot

Conversation

@PurHur

@PurHur PurHur commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • Zend / VM / AOT agree on test/repro/issue_34146_mb_strpos_runtime_aot.php (int(1), bool(false), int(6))
  • Offset + ASCII encoding AOT match Zend
  • ./script/aot-smoke.sh8 passed, 0 failed (via ./script/docker-exec.sh)
./script/docker-exec.sh -- bash -lc 'php test/repro/issue_34146_mb_strpos_runtime_aot.php && php bin/vm.php test/repro/issue_34146_mb_strpos_runtime_aot.php && PHP_COMPILER_HELPER_RUNTIME_O=0 php bin/compile.php -o /tmp/mbsp test/repro/issue_34146_mb_strpos_runtime_aot.php && /tmp/mbsp'
./script/docker-exec.sh -- bash -lc './script/aot-smoke.sh'

Not covered: peer *pos/*str family runtime leftovers (same JitMbSearch fold-only gap).

Made with Cursor

Literal fold already worked; non-constant haystack/needle now lower via
MbSearchJitHelper (NestedJIT-safe UTF-8 walk — VmString::utf8CharLength is silent-0 under thin AOT).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 8849dfb into master Aug 23, 2026
1 check failed
@PurHur
PurHur deleted the fix/34146-mb-strpos-runtime-aot branch August 23, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: mb_strpos() JIT/AOT happy-path leftover of #27187 — runtime args LogicException (ext/mbstring/mbstring.c)

1 participant