fix(web): replace zoom Reset button keyframe entrance with a transition - #27
Merged
PunGrumpy merged 1 commit intoAug 7, 2026
Conversation
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
PunGrumpy
force-pushed
the
motion/07-reset-button-transition
branch
from
August 7, 2026 16:50
d690152 to
58250af
Compare
The tw-animate-css entrance (animate-in fade-in zoom-in-95 slide-in-from-left-2) restarts from zero each time zoom crosses 1 and left duration/ease utilities applying to an implicit transition of every property. The button now enters via a scoped transition-[opacity,translate,scale] with @starting-style (Tailwind starting: variant) — interruptible, GPU-only, and reduced to a plain fade under prefers-reduced-motion by the global safe-list. Closes the remaining LOW audit finding noted in plans/README.md and clears react-doctor no-transition-all. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PunGrumpy
force-pushed
the
motion/07-reset-button-transition
branch
from
August 7, 2026 16:57
58250af to
2cc1de6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The zoom Reset button entered with tw-animate-css keyframes (
animate-in fade-in zoom-in-95 slide-in-from-left-2) — a keyframe restart every time zoom crosses 1, flagged by react-doctor (no-transition-all) and recorded as the remaining LOW finding from the motion audit (plans/README.md).Root Cause
Keyframe entrances restart from zero and are not interruptible; the bare
duration-150 ease-oututilities also left an unscoped transition.Solution
The button now enters via
transition-[opacity,translate,scale] duration-150 ease-outfrom astarting:(@starting-style) state ofopacity-0 -translate-x-2 scale-95— scoped, GPU-only, interruptible, and automatically reduced to a plain fade underprefers-reduced-motionby the global safe-list from #24.Result
Same visual entrance, no keyframe restarts, react-doctor flag cleared; the audit's LOW item is closed out in
plans/README.md.🤖 Generated with Claude Code