Conversation
In two examples (Buying Items, Accepting Offers), `OrderSide` is imported but not used in either of them. `fillOrder` and `getOrderByHash` neither accept nor return `OrderSide`. The import has been removed from both blocks - the example has been updated to reflect actual API usage.
Collaborator
|
Thanks @CryptAm, good catch. This repo is a read-only mirror of our monorepo, so I recreated your change there in ProjectOpenSea/opensea-devtools#784 (now merged) with you credited as co-author. It will ship in the next sdk release. Closing this one since mirror PRs can't be merged directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In two examples (Buying Items, Accepting Offers),
OrderSideis imported but not used in either of them.fillOrderandgetOrderByHashneither accept nor returnOrderSide.Solution
The import has been removed from both blocks - the example has been updated to reflect actual API usage.