Repository navigation
Conversation
The OpenSeaSDK implementation example in `@example` (src/index.ts) does not pass the `apiKey`. This is the only implementation example in the repository that omits the `apiKey`; `fast-start.md` and the JSDoc in `sdk.ts` include it everywhere. Without the `apiKey`, most API calls return an authorization error. `index.ts` serves as the package entry point - for instance, on the main documentation page generated by TypeDoc. The `apiKey` has been added to ensure consistency with the rest of the documentation and to ensure the code works correctl
Collaborator
|
Thanks @CryptAm. This repo is a read-only mirror of our monorepo, so I recreated your change there in ProjectOpenSea/opensea-devtools#784 (now merged) with you credited as co-author. It will ship in the next sdk release. Closing this one since mirror PRs can't be merged directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The OpenSeaSDK implementation example in
@example(src/index.ts) does not pass theapiKey.This is the only implementation example in the repository that omits the
apiKey;fast-start.mdand the JSDoc insdk.tsinclude it everywhere. Without theapiKey, most API calls return an authorization error.Solution
index.tsserves as the package entry point - for instance, on the main documentation page generated by TypeDoc. TheapiKeyhas been added to ensure consistency with the rest of the documentation and to ensure the code works correctl