Repository navigation
0.8.0: primitives as tables, capture protection only for our own screenshot - #71
Merged
Merged
Conversation
…ettings, named values, anchors, shapes) read by general generators A row in src/scene/kit-presets.ts names a part's fitting rules, its count settings and limits, the values that follow from its size (crank throw, rod ends, pin drop), its anchors and its list of shapes as formulas; src/scene/kit-expr.ts reads the formulas. The renderer's mechanism-parts.ts keeps only the general generators (lathe, cylinder, extruded outline, box, sphere, torus, coil, bolts). Anchors, crankThrow, rodEnds and pistonPinDrop come from the rows. A golden recording made from the unchanged builders (384 configurations: sizes, counts, variants, three levels of detail) is reproduced exactly; the guide text is byte for byte the same. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…mula language, the rows and adding a part as a row; the kit's place in the scene-language doc Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t), crank, cam and flash are rows over a few general motions src/scene/movement-rows.ts holds each kind as a row: the general motion it is (turn, slide, swell, bob, or follow a path), its default axis, where its cycle starts, its amount range and its numbers as formulas. motion.ts keeps the general passes that read the rows; the validator and the timeline read range, axis and start from the same row. A golden of 9,611 poses recorded from the old per-kind passes is reproduced exactly, with movement-golden for the engine; the guide is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… the part names and the loop kinds are read from the tables' keys Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…le's keys, so whole-project type checking is clean Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…shot setContentProtection was set once on every overlay, catcher and card window, which also took Talkthrough out of a person's recordings and screen shares. A capture shield now holds those windows and raises the flag just before each capture of ours (question, follow-up, guide-step screen check), waits for it to reach the composed picture while the source opens, and lowers it right after. Captures run one at a time, and the flag stays up while another is waiting. --visible-to-capture leaves the shield off; --capture-settle sets the wait. scripts/capture-check.cjs draws known-colour patches in windows of the app's kinds and captures both ways (and sweeps the wait); it needs a visible screen. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The settle promise was handed only to the capture that raised the protection, so a later capture that started while it was up read at once if the first failed before reading. The shield now keeps the pending wait while the windows are up and gives it to every capture that runs in that time. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pec now imports Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch with the version bump.
src/scene/kit-presets.ts) drawn by general generators; movement kinds (loops, crank, cam, flash) are catalogue rows (src/scene/movement-rows.ts). Part names and loop kinds are read from the tables, so a new row is usable from a scene alone. Output is identical: goldens recorded from the old code reproduce exactly, and the guide and schemas are byte-identical.Each change was independently reviewed; focused tests pass and the type check is clean.
🤖 Generated with Claude Code