Skip to content

Keep crowded panels from obscuring readable content - #65

Merged
ProjectIdris merged 2 commits into
ProjectIdris:mainfrom
hearthworksai:celyn/crowded-panel-admission
Nov 8, 2026
Merged

ProjectIdris merged 2 commits into
ProjectIdris:mainfrom
hearthworksai:celyn/crowded-panel-admission

Conversation

@hearthworksai

@hearthworksai hearthworksai commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

When placement cannot fit every readable surface, omit whole conflicting panels rather than painting text through text. This follow-up keeps the existing draft PR and changes which panels survive:

  • Reserve the stage first, then panels the current step adds or highlights, including highlighted diagram items. Newer panels win ties before older retained panels.
  • Let cleared surfaces yield to arriving replacements without a flashing crowded-panel cue. Reusing an id retires the old surface and its leaving annotations, including during a scene-wide fade.
  • Bind annotations to the last preceding containing diagram/image and preserve that exact owner through placement.
  • Keep pointed-at page regions as weighted preferences for flow growth; other panels, stage and controls remain hard blockers.
  • Measure actual animated bounds without painting, then paint admitted content once at the same timestamp. This preserves node easing and avoids bounds changing between admission and paint.
  • Cache cue measurement outside its live region and update live text only when the count changes.

Readable sizes and Frost styling remain. No stage-growth feature or scene-language limit change is included.

Verification of this follow-up

Twelve new regressions were observed failing before their fixes, then passing. They cover current-step ordering, retained follow-ups and highlights after their pulse, clear/replacement, annotation ownership, soft-obstacle regrowth, cue writes, ten frames of node easing and exact card bounds, same-id reuse, global fading and departing annotations.

  • Focused checks: 34 passed, zero failures/skips. Independent code review repeated all 34 and approved the final source after verifying its findings were fixed.
  • Full local suite: 1,969 tests; 1,948 passed, 20 skipped, one failure. The failure is the synthetic speech-server request to 127.0.0.2, which also fails on the prior clean baseline in this environment. Portable/native skips are not acceptance.
  • Typecheck, build and whitespace checks passed.
  • The crowded sweep uses six viewport sizes and one through twelve panels. Fitting layouts, removal of omitted pointer regions and owned annotations, clear/replacement and actual animated bounds are covered.

Bounded Windows offscreen/GPU-off before-and-after QA used the exact source tree above at 900×560 and 520×380. All 16 candidate identity/count/separation checks passed. The retained original snapshots show current-flow priority, clear/replacement, same-id replacement, actual retained second turns and the stage/cue. Exact-pixel reinspection confirmed the footer/cue in the fade snapshots as well. Highlight snapshots are byte-identical before/after. This is branch-only snapshot evidence, not continuous-animation or latest-main native-renderer acceptance.

The original harness completed the first baseline viewport, then failed loading the second hidden window. A harness-only lifecycle correction captured only the missing baseline viewport; the original failure and all images were retained. No product source changed for capture. The full local overlay test run was 911 tests: 909 passed, 2 platform skips, zero failures.

Exact source and integration

Published follow-up head: 50f9a4c.
Source tree: 29fb06f7d9aac93cea55c3fc4a38aa8462c7f64d.
The published source is byte-for-byte equivalent to tested local candidate dc1ec1a31e08203333468f287fea3e36d5e184ff. It appends to prior PR65 head23be619789a08f5f15233bdbe317991a8a862dae without rewriting the branch.

Verified upstream main: 5fcc816.
Actual GitHub synthetic merge: bbae772.
Synthetic merge tree: 762ce629fab31aff93c3e7f8e9a25019c2f08796.
Its parents are the verified main and this published follow-up. All 640 file modes/blobs match the expected three-way combination. The material library, PR66 movement code and PR67 version/package-lock updates are preserved. Independent static integration review found no blocker.

Both workflows completed successfully. Typecheck and build passed in all four jobs.

  • Source Linux: 1,969 tests; 1,946 passed, 23 skipped, zero failures.
  • Source Windows: 1,969 tests; all 1,969 passed, zero skips/failures.
  • Actual merge Linux: 2,033 tests; 2,009 passed, 24 skipped, zero failures.
  • Actual merge Windows: 2,033 tests; all 2,033 passed, zero skips/failures.

These hosted results are separate from the one known local loopback failure reported above. Skips are not native acceptance.

Limits

An extreme thirteen-panel layout at 480×340 can still evict the stage to make room for the cue. Stage growth and admission hysteresis remain separate follow-up work; growth should go through placement before invoking this fallback. Omitted panels still participate in placement. The cue reports a count, not panel names.

The existing five-panel renderer fixture deliberately exceeds the current three-diagram authoring cap to exercise retained/rendered surfaces. Earlier native evidence on old head23be619 established the original panel-over-panel fix, not this revision. Existing compact timeline-internal clipping is separate and unchanged.

Offscreen software-compositor evidence is not GPU, physical desktop-input or live-model acceptance. No visible application window, paid/provider call, deployment or merge was performed. This PR remains draft for review.

Admit panels using their actual painted bounds and existing paint order; omit conflicting panels with a visible count in a clear slot. Preserve Frost styling and fitting layouts. Release omitted annotations, pointer footprints and retained stage labels. Cover admission, lifecycle, exact ownership and size/count sweeps.

Source tree matches local/native verified candidate 06b18fe5ffb2519830af3471a31b0e52389fb214 exactly: 3a42589.
@ProjectIdris
ProjectIdris marked this pull request as ready for review November 8, 2026 07:21
@ProjectIdris
ProjectIdris merged commit f5ec90d into ProjectIdris:main Nov 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants