Repository navigation
Clarify default fibre treatments and guard connector rebuilds - #64
Merged
ProjectIdris merged 1 commit intoNov 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression controls
Both tests pass on current main. Each was also run against a separate, deliberate implementation break with assertions and timeouts unchanged, then rerun after restoring the production file byte-for-byte:
treated elastic connectors keep the current bulge and endpoint limits through contraction and reverse seeks: remove thecapDepthargument fromupdateConnectors'tubeGeometrycall. The test fails its rounded-end quarter-span assertion (observed bounds approximately -0.02 to 0.04 for a 0.02 span, versus allowed -0.005 to 0.025), then passes after restoration.named fibre materials retain their implicit treatment through contraction and reverse seeks: replacetreatmentOf(def)withdef.treatmentin the connector rebuild'ssetPathSurfaceCoordinatescall. The test fails because muscle/low geometry loses its material coordinates, then passes after restoration.These controls demonstrate regression detection, not a runtime defect in current main.
Validation
node --test --test-concurrency=2 'test/*.test.ts': 1,970 tests; 1,948 passed, 1 failed, 21 skipped.a synthetic speech server bound to 127.0.0.2 receives the configured local request, withUND_ERR_SOCKET/ local speech server unreachable. The same targeted test fails with the same socket error on an untouched checkout of base main.npm run typecheck,npm run build, andgit diff --check: passed.Limits
Native/desktop checks are among the skipped tests; the native fibre shader test requires a display server. This work makes no new GPU rendering, desktop visual-acceptance, or live-model latency claim.
Source
Tested tree:
5e9c8b47bbf1cc3945ef9208aec6960b8c795e15. Published head:3ae1588d07e2140f5e73cd813fcfec9b07ab5e8c, based directly on main21cd3c7d5e7d70e252a108da5ba6f8fa393fc9dd. Hosted CI is pending for this new head. Draft for review; no merge requested.