Skip to content

Keep hidden geometry out of visible model bounds - #61

Draft
hearthworksai wants to merge 2 commits into
ProjectIdris:mainfrom
hearthworksai:celyn/visible-model-bounds
Draft

hearthworksai wants to merge 2 commits into
ProjectIdris:mainfrom
hearthworksai:celyn/visible-model-bounds

Conversation

@hearthworksai

Copy link
Copy Markdown
Contributor

Summary

  • Keep fully hidden ancestors and descendants out of camera fitting, contact shadows, label/scissor bounds and cut bounds.
  • Hide detached cut caps along with their owners. Preserve visible descendants and instances, including transformed mesh parents and hide/show restoration.
  • Add regression coverage and a four-state comparison sample. No new scene fields, prompt requirements, geometry or dependencies.
  • Integrate current main 5ecf53b928de03cd55c9d1de02d7e95dffd240f7, retaining PR58 elastic bulge/endpoint limits, PR59 live attachments and schema transport on stdin. The original seven-file feature diff remains. The sole merge conflict was adjacent imports; both were retained.

Fresh integration evidence

  • Focused regression suite: 119 passed, 0 failed, 1 skipped (Windows-only local schema process check). Covers visible bounds/restoration, cutaway, elastic limits/connectors, live attachments, mounts, anchors, schema and subscription adapters.
  • Fresh red/green control: the ten integration tests against exact current-main scene3d/cutaway code produced 1 pass/9 expected failures; the restored candidate plus helper probe passed 11/11.
  • Typecheck, build and whitespace checks passed.
  • Full portable suite (concurrency 2): 1,925 passed, 1 failed, 20 skipped. Exact current-main baseline: 1,914 passed, 1 failed, 20 skipped. Both fail only the synthetic 127.0.0.2 speech-server request with a socket/unreachable error. No test gates were changed or failures retried. Native WebGL checks were unavailable and are not accepted by this run.
  • Independent integration diff review found no blocking issue and confirmed upstream attachment/anchor/join behavior is retained.

Historical evidence, before this refresh

These results belong to the original published tree 30fff2ab8e7ffa8218e3c35bb62b2e82e6e32090, not the refreshed integration tree.

  • A visible one-unit box was fitted at camera [0, 0, 2.64]. Adding a hidden group with a distant hundred-unit child incorrectly moved the baseline camera to [74.75, 0, 317.53]. The candidate retained the original framing and shadow.
  • Nine of ten integration regressions failed on the old baseline and passed with the change; the tenth guards restoration/lifecycle. A separate preservation probe covers mesh children, instances, nested transforms and sprites.
  • Original focused suite: 58 passed. Original local full suite: 1,876 passed, 1 failed, 20 skipped; old baseline: 1,865 passed, 1 failed, 20 skipped. Both shared the environment's synthetic 127.0.0.2 speech-server socket failure.
  • Original-head hosted CI 42436324286: Windows 1,897 passed/0 skipped and Ubuntu 1,874 passed/23 skipped; typecheck/build passed.
  • Original-source Windows hardware checks produced 24 RTX 3060 Ti/ANGLE captures across low/mid/high, 11 visible-bounds and 66 related test passes. Independent pixel review was positive across tiers, including byte-identical stable s0/s1 candidate frames in every tier. Whole-frame restoration equality is not established because of label history and the shared final idle-camera change.
  • Historical CPU-only 160-piece/six-level warm-sync microbenchmark: all-visible 0.97 ms candidate versus 0.76 ms baseline; half-hidden 0.47 ms versus 0.50 ms. These narrow local timings are not a performance improvement or GPU/end-to-end latency claim.

Limits

No fresh Windows, native capture, GPU or performance acceptance is claimed for the refreshed tree. Portable skips and failures are listed separately from historical native evidence. This change handles Object3D visibility; it does not introduce partial-opacity, material-visibility or billboard-bounds semantics.

Exact source

Published head dfc96180f2fc0c3b64700ad72a53e7dee0233c91, tree 54aa892dcbac9c8138fee5920070ecc50af66abb. All 625 tracked blobs/modes and all seven feature files were verified against the frozen local source. An independent publication check passed 49 focused tests plus typecheck/build. This remains a draft; fresh exact-head hosted CI and refreshed native acceptance are pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants