Repository navigation
docs(rqe-optimizer): port sketch-bench doc edits; fold case-studies-6.3.1 into case-studies - #920
Open
milindsrivastava1997 wants to merge 1 commit into
Open
milindsrivastava1997 wants to merge 1 commit into
milindsrivastava1997 wants to merge 1 commit into
Conversation
….3.1 into case-studies - docs: the asap_sketchlib 0.3.0 mentions, Hydra's footprint and the rows path, as sketch-bench#234 left them after the move. - results: case-studies-6.3.1 duplicated case-studies' base-0 (identical cost for every method and weight setting); its per-method tables now live in case-studies/README.md. - case-studies/README.md: the anomaly batch SLA does change the plan (0.114 -> 0.377); linear scaling holds only with no SLA; Fargate at 50 endpoints picks 2 MVs, not 1; restore the Caveats heading. - plot_sec63_paper.py: drop cost_bars' never-called wide layout (it would have overwritten sec63_cost_bars); the docstring lists every figure. All figures are byte-identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qhwq8JRnKRVPR15fxLXyq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftovers from the rqe-optimizer move (#915).
Docs. sketch-bench#234 edited
e2e_planning_flow.mdandrqe_optimizer_hydra.mdafter they were copied here. This ports its edits: the asap_sketchlib 0.3.0 mentions, Hydra's reported footprint (Hydra::memory_bytes), and the rows path (sketch-bench/sketch-bench/src/rows/mod.rs).results/case-studies-6.3.1/removed. Its two workloads arecase-studies/'sbase-0tables. The results match for every method (asap, asap-norollup, perquery, autosketch) under both CPU and Fargate weights. Its per-method tables and query listings now sit under "Every method on the base workloads" incase-studies/README.md.rqe-optimizer/README.mdnow points atcase-studies/.case-studies/README.mdcorrections (checked against the result files):plot_sec63_paper.py.cost_barswas only ever called with"column". Itswidebranch would have saved oversec63_cost_bars, which iscost_bars_single's output. The PR removes that branch, renames the function tocost_bars_columnand lists every figure in the docstring. I regenerated all six figures from main and from this branch, and the PNGs are byte-identical.Not in this PR: the
sketch-bench#159/#172/#189references inrqe-optimizer/srcstay as they are until those issues are moved here.🤖 Generated with Claude Code
https://claude.ai/code/session_014qhwq8JRnKRVPR15fxLXyq