Repository navigation
test(devtools): regenerate the ratio-of-quantiles sketch snapshot after the δ split - #1414
Merged
Merged
Conversation
…er the δ split #1360 changed an equal-cost tie in this plan: two pass-through nodes swap which one holds its 10,000-row output for one evaluation (None vs OneEvaluation); the plan's total cost and operators are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
corpus_snapshots(check mode) fails on main:sketch_plan_snapshots/ratio-of-quantiles-1h-mvp.jsonwas not regenerated when fix(accuracy): split δ over the readout values the covered output values depend on #1360 merged.UPDATE_SNAPSHOTS=1 cargo test --release -p asap-devtools --test corpus_snapshots -- --ignored.lifetimeNone ↔OneEvaluation(Memory)); each node's cost moves by the same 6.1e-17/s in opposite directions, so the plan's total cost and its operators are unchanged. fix(accuracy): constraint (K) checks the union bound over the estimates each query depends on #1405 produces the byte-identical file.