Skip to content

fix(ci): green main on the current toolchain - #1399

Merged
zzylol merged 1 commit into
mainfrom
fix/ci-main-green
Nov 17, 2026
Merged

zzylol merged 1 commit into
mainfrom
fix/ci-main-green

Conversation

@zzylol

@zzylol zzylol commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Problem: Rust CI fails on main (1760a69f5) in both jobs, so every PR shows red for reasons unrelated to its diff:
    • clippy 1.100 denies approx_constant for the hand-written Euler–Mascheroni constant in asap-cost (state_bytes/mod.rs:356);
    • asap-types imports StorageMedium at module level but uses it only in a test/test-support function, so a plain lib build warns (denied by -D warnings);
    • rust.yml:109 runs tools/dag-viewer/enumeration.test.mjs, which refactor: tools and snapshots over the #1207 memo, edges and contexts (#1207 PR 9) #1239 deleted;
    • tools/verify_metricsql_external_consumer.sh calls lower_metricsql with the old three-argument signature.
  • Change: use std::f64::consts::EULER_GAMMA; qualify StorageMedium at its one test-support use; drop the deleted test file from the workflow; call lower_metricsql(query, sample_interval).
  • Effect: no behavior change (the constant is the same value; the other edits touch CI and a test-support path only).

Verification

  • cargo clippy -p asap-types -p asap-cost --all-targets -- -D warnings and cargo clippy -p asap-types --all-targets --all-features -- -D warnings: clean.
  • cargo test -p asap-cost --lib state_bytes: 10 passed.
  • tools/verify_metricsql_external_consumer.sh: the external consumer builds.
  • cargo fmt --all --check: clean.

…he deleted enumeration viewer test, update the MetricsQL consumer check to lower_metricsql's two-argument signature, scope a test-only import
@zzylol zzylol added bug Something isn't working testing Corpus, regression, differential, or benchmark tests labels Nov 17, 2026
@zzylol
zzylol merged commit b511e4f into main Nov 17, 2026
2 of 3 checks passed
@zzylol
zzylol deleted the fix/ci-main-green branch November 17, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Corpus, regression, differential, or benchmark tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant