Repository navigation
fix(ci): green main on the current toolchain - #1399
Merged
Merged
Conversation
…he deleted enumeration viewer test, update the MetricsQL consumer check to lower_metricsql's two-argument signature, scope a test-only import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rust CIfails on main (1760a69f5) in both jobs, so every PR shows red for reasons unrelated to its diff:approx_constantfor the hand-written Euler–Mascheroni constant inasap-cost(state_bytes/mod.rs:356);asap-typesimportsStorageMediumat module level but uses it only in atest/test-supportfunction, so a plain lib build warns (denied by-D warnings);rust.yml:109runstools/dag-viewer/enumeration.test.mjs, which refactor: tools and snapshots over the #1207 memo, edges and contexts (#1207 PR 9) #1239 deleted;tools/verify_metricsql_external_consumer.shcallslower_metricsqlwith the old three-argument signature.std::f64::consts::EULER_GAMMA; qualifyStorageMediumat its one test-support use; drop the deleted test file from the workflow; calllower_metricsql(query, sample_interval).Verification
cargo clippy -p asap-types -p asap-cost --all-targets -- -D warningsandcargo clippy -p asap-types --all-targets --all-features -- -D warnings: clean.cargo test -p asap-cost --lib state_bytes: 10 passed.tools/verify_metricsql_external_consumer.sh: the external consumer builds.cargo fmt --all --check: clean.